Have a weird question here…So I had a pull request (called PR #X) open that was more or less a “gem install” into a Ruby file. It had 2 code review signoffs by senior developers and was ready to be merged, pending testing on our CI server (which wasn’t working due to a reason beyond our control at the moment). One of the QA folks I work with wanted to get his own PR (PR #Y) in that added an ENV variable that worked with the gem (installing this gem dependent on rspec was a priority of his, though not necessarily the dev team’s). I was going to merge it in but then for some inexplicable reason my tests broke and I couldn’t get them working and had other high priority stuff come up. Also told him we probably had to wait to merge anyway because our CI server wasn’t working.
So then the guy closed my PR without asking me and said they put my changes in his own PR and then asked our slack channel to review his new PR #Z (a combination of X and Y) instead. This all happened within the span of 1.5 days. There was no real urgency in a business sense in terms of getting PR #Z merged, it was just one of those things we wanted to start adding to your workflow (sort of on the order of switching from Sublime to Vim)
My question is - would you have asked the person before you closed their PR (and if you would, is it considered rude not too ask)? And in general, is there any general etiquette around pull requests and the like? In general, I try to close them as fast as possible and if it were me, I would have talked to the person first.