Feedback on a ruby/git tutorial post I'm working on - Git as a KV store

ybur_yug · June 16, 2015, 11:51pm

Would love to hear what you guys think of it so far.

AstonJ · June 17, 2015, 10:41am

Looks really good Bobby - exactly the sort of thing to put on a blog imo (things kinda get lost in all the noise on github).

I couldn’t see the slides though, it kept saying it was waiting for you to get online

RedFred7 · June 18, 2015, 1:23pm

interesting stuff. Want to have a play with this over the weekend.

ybur_yug · June 24, 2015, 6:26pm

the full gem can be found here

RedFred7 · June 25, 2015, 9:21pm

unfortunately failed on the require @ybur_yug

/home/fred/.rvm/rubies/ruby-2.1.3/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require’: /home/fred/.rvm/gems/ruby-2.1.3@fred1/gems/gkv-0.2.2/lib/gkv/database.rb:35: syntax error, unexpected ‘:’, expecting => (SyntaxError)
{ “#{key}”: value }

it’s because you’re using the symbol-expecting hash syntax with a string. It’ll be ok if you use { “#{key}” => value }.

do you accept pull requests?

ybur_yug · June 25, 2015, 9:41pm

Absolutely. The gem was in flux until today when I finished up some bugfixes. I would clone + build from source to be sure this still happens (if you didnt do it today, after about 3-4pm eastern). Currently the CI build is all passing so I’m not sure if this is still an issue.

Let me know. Open an issue on github and we can converse in there further so its documented with the repo if it is still existing
Thanks @RedFred7 !

RedFred7 · June 25, 2015, 9:46pm

no probs, will do it tomorrow. Off to beddy-byes now

ybur_yug · June 25, 2015, 9:48pm

Sleep well! for reference this is the set of tests that SHOULD catch that, let me know if i missed something etc

github.com

ybur-yug/gkv/blob/master/spec/gkv_spec.rb#L47


it 'modifies a key with hash syntax' do
  db['Apples'] = 12
  db['Apples'] = 10
  expect(db['Apples']).to eq 10
end
it 'keeps a history of a keys values' do
  load_db([{ 'Pants' => 10 }, { 'Pants' => 'oats' }])
  expect(db.get_version(1, 'Pants')).to eq 10
  expect(db.get_version(2, 'Pants')).to eq 'oats'
end
it 'can set values containing quotes' do
  db['TestingQuotes'] = %(single ' and double " quote)
  expect(db['TestingQuotes']).to eq %(single ' and double " quote)
end
it 'can return a float type' do
  load_db([{ 'Pants' => 10.0 }])
  expect(db.get('Pants')).to eq 10.0
end